(feat) add example Gateway scripts #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikspz
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Tests performed:
- Cloned and installed feature branch
- connected uniswap ethereum goerli
- started/run amm_price_example script usin WETH-DAI - bot showed raw price without Decimal separator
- Changed pair manually and started/run price script - reviewed price changed
- failed to execute tx on uniswap_ethereum_goerli
- started/run amm_trade_example using WAVAX-USDT on pangolin - reviewed txHash, transaction is successful
Note: trades are not recorded for script in CSV or SQLite, however trades recorded in logs
cardosofede
reviewed
Feb 23, 2023
| """ | ||
| # swap params | ||
| connector_chain_network = "uniswap_ethereum_goerli" | ||
| trading_pair = {"WETH-DAI"} |
There was a problem hiding this comment.
it's better to just use the string here so later one you don't have to manipulate the variable to get the trading pair
cardosofede
approved these changes
Feb 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Initial sample scripts for use by developers using Gateway