Refactor/amm arb sync price request #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trategy waiting time
yancong001
force-pushed
the
refactor/amm_arb_sync_price_request
branch
from
9534915
to
2714056
Compare
yancong001
force-pushed
the
refactor/amm_arb_sync_price_request
branch
from
678eff1
to
e23bf4f
Compare
|
Approved from an engineering standpoint - I agree that checking both legs concurrently is a big improvement! Tips for QA
|
fengtality
approved these changes
Jun 14, 2023
nikspz
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Tests performed:
- Clone and install refactor branch + gateway development
- connected uniswap arbitrum one and goerli successfully
- created amm_arb strategies using uniswap goerli and binance paper trade, uniswap arbitrum one and binance paper trade (WETH-USDC.E)
- started and review profitability rate
- configured profitability to -0.9 for arbitrum and -200 for uniswap goerli
- Started and Reviewed order execution is consistent
- profitability is correct for goerli and arbitrum_one mainnet
- Manually created docker image for PR successfully
- cloned deploy-examples repo and set up hummingbot_compose_gateway successfully
- Created/started amm_arb uniswap goerli, review order execution is consistent
|
Merged the PR in behalf of foundation team to development and will be available on the next version 1.17.0 |
This was referenced Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR optimizes price requests to asynchronous concurrent requests in function 'create_arb_proposals' to save amm_arb strategy waiting time
Tests performed by the developer:
Tips for QA testing: