Feat/make dexalot api key optional #6271

vic-en · 2023-04-28T22:17:13Z

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This pr deprecates Dexalot's api key.
[ch39631]

Tests performed by the developer:

Reconnecting Dexalot connector.

Tips for QA testing:

Perform end-to-end testing with gateway pr - Feat/make dexalot api key optional gateway#98

This reverts commit 5946642.

fengtality

Please make the change requested to the warning

fengtality · 2023-05-03T06:16:28Z

hummingbot/connector/exchange_py_base.py

@@ -259,6 +260,7 @@ def quantize_order_amount(self, trading_pair: str, amount: Decimal, price: Decim

        # Add 1% as a safety factor in case the prices changed while making the order.
        if notional_size < trading_rule.min_notional_size * Decimal("1.01"):
+            self.logger().warning("Quantizing order amount to 0 because order notional value is not up to expected minimum notional value.")


Please replace with:
self.logger().warning(f"Quantizing order amount to 0 because order notional value is below {trading_rule.min_notional_size} market minimum notional value.")

hummingbot/connector/exchange_py_base.py

nikspz · 2023-05-03T18:28:52Z

Latest commit: a9d45c4

Got in issue at the start of the HB instance

Steps to reproduce:

Clone and install feature branch
Start the instance

2023-05-03 18:14:31,450 - 124563 - hummingbot.core.utils.trading_pair_fetcher - ERROR - An error occurred when fetching trading pairs for hotbit.Please check the logs
Traceback (most recent call last):
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 53, in fetch_all
    self._fetch_pairs_from_connector_setting(connector_setting=conn_setting)
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 38, in _fetch_pairs_from_connector_setting
    connector = connector_setting.non_trading_connector_instance_with_default_configuration()
  File "/home/ubuntu/dexalot6271/hummingbot/client/settings.py", line 308, in non_trading_connector_instance_with_default_configuration
    connector_class = getattr(importlib.import_module(self.module_path()), self.class_name())
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange/hotbit/hotbit_exchange.py", line 19, in <module>
    from hummingbot.connector.exchange_py_base import ExchangePyBase
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange_py_base.py", line 263
    self.logger().warning("f"Quantizing order amount to 0 because order notional value is below {trading_rule.min_notional_size} market minimum notional value.")
                             ^
SyntaxError: invalid syntax
2023-05-03 18:14:31,461 - 124563 - hummingbot.core.utils.trading_pair_fetcher - ERROR - An error occurred when fetching trading pairs for kucoin.Please check the logs
Traceback (most recent call last):
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 53, in fetch_all
    self._fetch_pairs_from_connector_setting(connector_setting=conn_setting)
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 38, in _fetch_pairs_from_connector_setting
    connector = connector_setting.non_trading_connector_instance_with_default_configuration()
  File "/home/ubuntu/dexalot6271/hummingbot/client/settings.py", line 308, in non_trading_connector_instance_with_default_configuration
    connector_class = getattr(importlib.import_module(self.module_path()), self.class_name())
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange/kucoin/kucoin_exchange.py", line 16, in <module>
    from hummingbot.connector.exchange_py_base import ExchangePyBase
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange_py_base.py", line 263
    self.logger().warning("f"Quantizing order amount to 0 because order notional value is below {trading_rule.min_notional_size} market minimum notional value.")
                             ^
SyntaxError: invalid syntax
2023-05-03 18:14:31,526 - 124563 - hummingbot.core.utils.trading_pair_fetcher - ERROR - An error occurred when fetching trading pairs for btc_markets.Please check the logs
Traceback (most recent call last):
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 53, in fetch_all
    self._fetch_pairs_from_connector_setting(connector_setting=conn_setting)
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 38, in _fetch_pairs_from_connector_setting
    connector = connector_setting.non_trading_connector_instance_with_default_configuration()
  File "/home/ubuntu/dexalot6271/hummingbot/client/settings.py", line 308, in non_trading_connector_instance_with_default_configuration
    connector_class = getattr(importlib.import_module(self.module_path()), self.class_name())
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange/btc_markets/btc_markets_exchange.py", line 19, in <module>
    from hummingbot.connector.exchange_py_base import ExchangePyBase
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange_py_base.py", line 263
    self.logger().warning("f"Quantizing order amount to 0 because order notional value is below {trading_rule.min_notional_size} market minimum notional value.")
                             ^
SyntaxError: invalid syntax
2023-05-03 18:14:31,538 - 124563 - hummingbot.core.utils.trading_pair_fetcher - ERROR - An error occurred when fetching trading pairs for bybit.Please check the logs
Traceback (most recent call last):
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 53, in fetch_all
    self._fetch_pairs_from_connector_setting(connector_setting=conn_setting)
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 38, in _fetch_pairs_from_connector_setting
    connector = connector_setting.non_trading_connector_instance_with_default_configuration()
  File "/home/ubuntu/dexalot6271/hummingbot/client/settings.py", line 308, in non_trading_connector_instance_with_default_configuration
    connector_class = getattr(importlib.import_module(self.module_path()), self.class_name())
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange/bybit/bybit_exchange.py", line 13, in <module>
    from hummingbot.connector.exchange_py_base import ExchangePyBase
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange_py_base.py", line 263
    self.logger().warning("f"Quantizing order amount to 0 because order notional value is below {trading_rule.min_notional_size} market minimum notional value.")
                             ^
SyntaxError: invalid syntax
2023-05-03 18:14:31,540 - 124563 - hummingbot.core.utils.trading_pair_fetcher - ERROR - An error occurred when fetching trading pairs for bybit_testnet.Please check the logs
Traceback (most recent call last):
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 53, in fetch_all
    self._fetch_pairs_from_connector_setting(connector_setting=conn_setting)
  File "/home/ubuntu/dexalot6271/hummingbot/core/utils/trading_pair_fetcher.py", line 38, in _fetch_pairs_from_connector_setting
    connector = connector_setting.non_trading_connector_instance_with_default_configuration()
  File "/home/ubuntu/dexalot6271/hummingbot/client/settings.py", line 308, in non_trading_connector_instance_with_default_configuration
    connector_class = getattr(importlib.import_module(self.module_path()), self.class_name())
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange/bybit/bybit_exchange.py", line 13, in <module>
    from hummingbot.connector.exchange_py_base import ExchangePyBase
  File "/home/ubuntu/dexalot6271/hummingbot/connector/exchange_py_base.py", line 263
    self.logger().warning("f"Quantizing order amount to 0 because order notional value is below {trading_rule.min_notional_size} market minimum notional value.")
                             ^
SyntaxError: invalid syntax

logs_hummingbot.log

nikspz · 2023-05-04T05:58:58Z

@vic-en I'm not sure this is working as expected

Steps:
Clone and install
Start the strategy with order amount lower than min

Test performed:

Cloned and installed feature branch
Connected dexalot without dexalot_API_key successfully
Created/started strategies using AVAX-USDC, WETH.E-USDC, BTC.B-USDC successfully
Order cancellation: ok
Status --live and order_book --live sync with the exachange
Filled order events: ok
CSV, Sqlite, history matched with the exchange
connected dexalot using dexalot_API_key successfully

hummingbot/connector/exchange_py_base.py

vic-en · 2023-05-05T06:05:28Z

@nikspz sorry about that. I updated it again.

nikspz

@vic-en fixed

Test performed:

Cloned and installed feature branch
Connected dexalot without dexalot_API_key successfully
Created/started strategies using AVAX-USDC, WETH.E-USDC, BTC.B-USDC successfully
Order cancellation: ok
Status --live and order_book --live sync with the exchange
Filled order events: ok
CSV, Sqlite, history matched with the exchange
connected dexalot using dexalot_API_key successfully
Created docker image manually successfully

deprecagte api key

5946642

vic-en mentioned this pull request Apr 28, 2023

Feat/make dexalot api key optional hummingbot/gateway#98

Merged

2 tasks

vic-en closed this Apr 28, 2023

vic-en added 3 commits May 2, 2023 02:18

Revert "deprecagte api key"

1d97e95

This reverts commit 5946642.

make api key optional

394723b

add unit test

a938fdf

vic-en reopened this May 3, 2023

vic-en changed the base branch from master to development May 3, 2023 00:28

vic-en changed the title ~~Feat/deprecate dexalot api key~~ Feat/make dexalot api key optional May 3, 2023

vic-en mentioned this pull request May 3, 2023

deprecate api key CoinAlpha/hummingbot#351

Closed

2 tasks

Merge branch 'development' into feat/deprecate_dexalot_api_key

256295d

fengtality previously approved these changes May 3, 2023

View reviewed changes

add warning when quanting order amount to zero.

d85ab1c

vic-en dismissed fengtality’s stale review via d85ab1c May 3, 2023 04:25

fengtality requested changes May 3, 2023

View reviewed changes

vic-en commented May 3, 2023

View reviewed changes

hummingbot/connector/exchange_py_base.py Outdated Show resolved Hide resolved

Update hummingbot/connector/exchange_py_base.py

a9d45c4

remove syntax error

090b60b

nikspz requested review from fengtality and cardosofede May 4, 2023 06:10

vic-en commented May 5, 2023

View reviewed changes

hummingbot/connector/exchange_py_base.py Outdated Show resolved Hide resolved

vic-en added 2 commits May 5, 2023 01:04

Update hummingbot/connector/exchange_py_base.py

17f8a30

Merge branch 'development' into feat/deprecate_dexalot_api_key

eab7ff4

nikspz approved these changes May 5, 2023

View reviewed changes

fengtality approved these changes May 6, 2023

View reviewed changes

fengtality merged commit 1730535 into hummingbot:development May 6, 2023
2 checks passed

fengtality deleted the feat/deprecate_dexalot_api_key branch May 6, 2023 02:51

nikspz mentioned this pull request May 22, 2023

sync / development -> staging #6315

Closed

2 tasks

rapcmia mentioned this pull request May 23, 2023

sync / development -> staging #6317

Merged

2 tasks

nikspz mentioned this pull request May 29, 2023

sync / staging -> master for Hummingbot version 1.16.0 #6337

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/make dexalot api key optional #6271

Feat/make dexalot api key optional #6271

vic-en commented Apr 28, 2023 •

edited

fengtality left a comment

fengtality May 3, 2023

nikspz commented May 3, 2023

nikspz commented May 4, 2023 •

edited

vic-en commented May 5, 2023

nikspz left a comment •

edited

Feat/make dexalot api key optional #6271

Feat/make dexalot api key optional #6271

Conversation

vic-en commented Apr 28, 2023 • edited

fengtality left a comment

Choose a reason for hiding this comment

fengtality May 3, 2023

Choose a reason for hiding this comment

nikspz commented May 3, 2023

nikspz commented May 4, 2023 • edited

vic-en commented May 5, 2023

nikspz left a comment • edited

Choose a reason for hiding this comment

vic-en commented Apr 28, 2023 •

edited

nikspz commented May 4, 2023 •

edited

nikspz left a comment •

edited