Feat/order types binance #6279
Merged
Feat/order types binance #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapcmia
approved these changes
May 4, 2023
There was a problem hiding this comment.
LGTM:
- Test using Fede's sample script, ok
- Test using amm-arbitrage on two different CEX (kucoin/binance)
- Trade data overview
- Order type recorded on history is MARKET
- CSV file recorded is MARKET
- Fees still matched
- Compare results on latest development branch, current supports LIMIT
fengtality
approved these changes
May 8, 2023
|
Merged to development and part of hummingbot version 1.16.0 |
This was referenced May 10, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Based on the Technical Roadmap, we are going to support all order types.
In this case, this PR will allow sending market orders with binance spot.
Tests performed by the developer:
I created this script: https://gist.github.com/cardosofede/d928c52503ef0b945ae140971f8fbbf3 that buy x amount at market and sell the same amount.
Tips for QA testing:
Use that script with api keys of binance connected