Feat/add trade fee in base and quote #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardosofede
force-pushed
the
feat/add_trade_fee_in_base_and_quote
branch
from
2514b1f
to
9270c5b
Compare
fengtality
reviewed
May 9, 2023
| @@ -260,11 +266,11 @@ def _did_fill_order(self, | |||
| order_id=order_id, | |||
| trade_type=evt.trade_type.name, | |||
| order_type=evt.order_type.name, | |||
| price=Decimal( | |||
There was a problem hiding this comment.
Is this change needed?
| "position", ] | ||
|
|
||
| self.assertEqual(expected_attributes, TradeFill.attribute_names_for_file_export()) | ||
|
|
||
| def test_attribute_names_for_file_export_are_valid(self): |
There was a problem hiding this comment.
Why remove this test instead of adding an mock entry for trade_fee_in_quote?
fengtality
approved these changes
May 9, 2023
nikspz
approved these changes
May 10, 2023
There was a problem hiding this comment.
Tests performed:
- Cloned and install feature branch and PR6288
- Manually Created docker image successfully
- conda env create -f environment_conda.yml
- conda activate streamlit-apps
- streamlit run main.py
- Copied URL to browser
- Created symlink with ln -s /path/to/hummingbot/data data
- Review Strategy Performance tab now shows fees in USDT for binance spot
- Confirmed fees amount is showing correct amount
Note: for binance perpetual there's ongoing issue on dashboard's Strategy Performance tab with AttributeError: module 'ccxt' has no attribute 'binance_perpetual'
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Add the value of the trade fee in quote asset. This is very useful for reporting purposes since if the fees are paid in another token, the rate oracle can be used to translate this difference.
Tests performed by the developer:
Run a bot and see that everything is working.
Test the new solution with the dashboard
Tips for QA testing: