Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add kucoin spot candles feed #6345

Conversation

tomasgaudino
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Add kucoin spot candles following binance structure
  • Standardize interval management (1m vs 1min vs ...)

Sadly, Kucoin hasn't developed klines with web socket yet. I'll be waiting for more updates in candles_base.py so it can handle only rest calls

Tests performed by the developer:

Tips for QA testing:

  • Try using this:
# Replace in scripts/candles_example.py

eth_1m_candles = CandlesFactory.get_candle(connector="kucoin",
                                           trading_pair="ETH-USDT",
                                           interval="1m", max_records=500)
eth_1h_candles = CandlesFactory.get_candle(connector="kucoin",
                                           trading_pair="ETH-USDT",
                                           interval="1h", max_records=500)
eth_1w_candles = CandlesFactory.get_candle(connector="kucoin",
                                           trading_pair="ETH-USDT",
                                           interval="1w", max_records=50)```

@rapcmia rapcmia linked an issue May 31, 2023 that may be closed by this pull request
@rapcmia
Copy link
Contributor

rapcmia commented Jun 1, 2023

Hi @tomasgaudino good day
Can you please check the failed tests below, thank you

image

@tomasgaudino
Copy link
Contributor Author

Hi @rapcmia, sure!

I'll be fixing this as soon as possible :)

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

  • OHLC matched
  • Volume and quote_asset_volume ok
  • Observed some data not available yet and will be improve on future updates for the Kucoin connector

@tomasgaudino
Copy link
Contributor Author

@rapcmia done!

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cardosofede cardosofede merged commit 2b61e66 into hummingbot:development Jun 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kucoin Spot and Perpetuals Candles Feed
4 participants