Feat/remove hotbit #6359
Merged
Feat/remove hotbit #6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-hummingbot
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Source Build
- source build successful
- launch client + password login successful
- run
connectcommand and verified hotbit is removed from list and autocomplete - tried to start strategy with hotbit and checked if connector is showing in the suggested list
Docker Build
- source build successful
- launch client + password login successful
- run
connectcommand and verified hotbit is removed from list and autocomplete - tried to start strategy with hotbit and checked if connector is showing in the suggested list
nikspz
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Test performed:
- Cloned and installed Source build successfully
- Verified hotbit is removed from connect list and strategy creation autocomplete
- Manually built docker image successfully
- Created docker instance and review hotbit removed
- Review hotbit files was removed
This was referenced Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Remove Hotbit from the codebase based on the last poll
Tests performed by the developer:
Tips for QA testing: