Feat/add delay between signals #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapcmia
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
LGTM
- Observe behavior of directional_strategy script when delay_between signals is set with different internvals {5s,10s,120s}
- After a position executor is closed, there will be a delay depending on the set
delay_between_signalsthen it checks the signal - Tested with tight RSA values to ensure we can open a position and
time_limit
|
HI @cardosofede i tried to run the Github CI and getting this result 2/2 |
|
@rapcmia fixed! |
|
Merged PR on behalf of the foundation team to development and will be available on release version 1.18.0 |
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Add functionality of delay between signals requested by a community member
Tests performed by the developer:
run a directional strategy that returns all the time 1 and check that the script waits until the next signal
Tips for QA testing: