Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fixed_grid_script_added #6495

Merged
merged 6 commits into from Jul 25, 2023

Conversation

rkc2000
Copy link
Contributor

@rkc2000 rkc2000 commented Jul 20, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Add the fixed grid script for spot markets to the codebase.

Tests performed by the developer:
Paper trading and live runs have been performed.

Tips for QA testing:

@nikspz nikspz linked an issue Jul 20, 2023 that may be closed by this pull request
@rkc2000
Copy link
Contributor Author

rkc2000 commented Jul 20, 2023

Tests are failing, I think because of isort failing.. not sure why. Can you help @cardosofede ?

@nikspz nikspz changed the title fixed_grid_script_added feat/fixed_grid_script_added Jul 21, 2023
@nikspz nikspz changed the title feat/fixed_grid_script_added Feat/fixed_grid_script_added Jul 21, 2023
@fengtality
Copy link
Sponsor Contributor

@rkc2000 There are linting issues with your script. Please activate the conda hummingbot environment before committing. It will show you the issues to fix:

Flake8...................................................................Failed
- hook id: flake8
- exit code: 1

scripts/fixed_grid.py:53:89: E226 missing whitespace around arithmetic operator
scripts/fixed_grid.py:56:64: E226 missing whitespace around arithmetic operator
scripts/fixed_grid.py:59:62: E226 missing whitespace around arithmetic operator
scripts/fixed_grid.py:62:88: E226 missing whitespace around arithmetic operator
scripts/fixed_grid.py:64:62: E226 missing whitespace around arithmetic operator
scripts/fixed_grid.py:68:67: E226 missing whitespace around arithmetic operator
scripts/fixed_grid.py:117:73: W291 trailing whitespace
scripts/fixed_grid.py:130:76: W291 trailing whitespace
scripts/fixed_grid.py:161:46: E231 missing whitespace after ','
scripts/fixed_grid.py:180:1: W293 blank line contains whitespace
scripts/fixed_grid.py:192:1: W293 blank line contains whitespace
scripts/fixed_grid.py:210:1: W293 blank line contains whitespace
scripts/fixed_grid.py:212:5: E303 too many blank lines (2)
scripts/fixed_grid.py:256:1: W293 blank line contains whitespace
scripts/fixed_grid.py:263:69: W291 trailing whitespace
scripts/fixed_grid.py:264:1: W293 blank line contains whitespace
scripts/fixed_grid.py:[27](https://github.com/hummingbot/hummingbot/actions/runs/5616226672/job/15218158256#step:6:28)6:13: E225 missing whitespace around operator
scripts/fixed_grid.py:[29](https://github.com/hummingbot/hummingbot/actions/runs/5616226672/job/15218158256#step:6:30)3:1: W293 blank line contains whitespace
scripts/fixed_grid.py:[30](https://github.com/hummingbot/hummingbot/actions/runs/5616226672/job/15218158256#step:6:31)5:5: E303 too many blank lines (2)
scripts/fixed_grid.py:308:92: W291 trailing whitespace

@rkc2000
Copy link
Contributor Author

rkc2000 commented Jul 21, 2023

@fengtality I think I've fixed those in the previous commits. The latest tests show Flake8 passing but isort failing.

Screenshot 2023-07-21 at 15 25 04

@fengtality
Copy link
Sponsor Contributor

fengtality commented Jul 21, 2023 via email

@rkc2000
Copy link
Contributor Author

rkc2000 commented Jul 21, 2023

Checks are passing now (I ran isort command on the script file locally and committed the changes).

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cardosofede cardosofede merged commit 17b8987 into hummingbot:development Jul 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid Strategy Experiment
3 participants