New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fixed_grid_script_added #6495
Feat/fixed_grid_script_added #6495
Conversation
Tests are failing, I think because of isort failing.. not sure why. Can you help @cardosofede ? |
@rkc2000 There are linting issues with your script. Please activate the conda
|
@fengtality I think I've fixed those in the previous commits. The latest tests show Flake8 passing but isort failing. |
isort is similar. I think it will make the changes itself when you run git
commit
…On Fri, Jul 21, 2023, 10:27 AM rkc2000 ***@***.***> wrote:
@fengtality <https://github.com/fengtality> I think I've fixed those in
the previous commits. The latest tests show Flake8 passing but isort
failing.
[image: Screenshot 2023-07-21 at 15 25 04]
<https://user-images.githubusercontent.com/6465285/255201900-5cf7d687-7ef1-4f10-b1b6-2e04c28a140a.png>
—
Reply to this email directly, view it on GitHub
<#6495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANWHVQUYC7FFSCSWYBW7RLXRKGWNANCNFSM6AAAAAA2RR63OA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Checks are passing now (I ran isort command on the script file locally and committed the changes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Add the fixed grid script for spot markets to the codebase.
Tests performed by the developer:
Paper trading and live runs have been performed.
Tips for QA testing: