New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/injective spot offline vaults #6512
Feat/injective spot offline vaults #6512
Conversation
…he vaults data source implementation
…ut the off-chain vault mode
…com/aarmoa/hummingbot into feat/injective_spot_offline_vaults
…com/aarmoa/hummingbot into feat/injective_spot_offline_vaults
… sent by the libraries to the stderr braking the bot interface
…com/aarmoa/hummingbot into feat/injective_spot_offline_vaults
…to feat/injective_spot_offline_vaults
…the full subaccount id to create orders with delegated accounts
… use the full subaccount id for delegated accouns, but the subaccount index only for vaults
Hello @rapcmia
Good catch, I have pushed already a fix for this.
The connector has a default configuration that is used when querying for the available trading pairs. And those characters you see are the way Hummingbot displays the Pydantic configuration instances (the default way for Pydantic). If you want to change that it will be a task for the foundation. Changing the way Pydantic is used in Hummingbot is outside the scope of this PR (@cardosofede) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Connector does not require gateway connection
- Check
{binance, kucoin, ascendex and gateio}
spot and perpetual conenctors due to changes on connector configration usign full Pydantic config - Setup Injective_v2
- Connector status now only display
injective_v2
- On setup, user can select between:
- Network to connect
{mainnet_network, testnet_network, custom_nework}
custom_network
no tested ❌
- Supports two account configuration
{delegate_account, vault_account}
vault_account
not tested ❌
- Network to connect
- Successfully connected wallets for mainnet and testnet
- Ran balance command, ok
- Ran tests on PMM for both networks
- Connector status now only display
- Fixed issues related to mainnet
- Build docker image and did the same tests
There are minor UI issues related to Pydantic config as adviced by developer. The foundation team will have a look on this concern. Other than that PR is good to be approve under bronze standards. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR expands the capabilities of the Injective V2 spot connector, adding logic to support trading through off-line vaults.
The PR also includes a refactoring to the connectors's configuration in order to allow connectors to use full Pydantic configurations (meaning that the connectors now can have configuration models with N submodels, each of them supporting the use of secret parameters)
The new version is backwards compatible and the connectors will still be using the old configuration style model, unless they explicitly declare the use the new module (with this PR only Injective V2 spot connector uses the new configuration model).
There is also an improvement in the logic that checks the orders are included in a transaction. Now the connector updates the order hashes in case they were incorrectly calculated locally in the bot, to reduce the chances of producing lost orders.
Tests performed by the developer:
Added unit tests for the new logic.
All tests passing in green.
Tips for QA testing:
Validate that old connectors can still be configured as usual.
Validate that the private key for Injective V2 connectors is stored in the config file encrypted
This PR is a continuation of the work done in #6493. No need for a PRP.