New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/injective perpetual with delegation #6521
feat/injective perpetual with delegation #6521
Conversation
…ers (delegate account data source only)
…nd trade updates. Also added logic to process orders, trades and balances events.
…account id for both spot and perpetual markets
…om/aarmoa/hummingbot into feat/injective_perpetual_with_delegation
…ve V2 vault spot branch
…rrent price is NaN
… the changes added to the Injective data sources when implementing the perpetual markets for delegate accounts
…hen there are no market orders, or no limit orders
…turn trading rules and fees for spot and derivative markets
…to feat/injective_perpetual_with_delegation
…e intention is to simplify the account configuration for the user.
…r the subaccount used by the connector
…aults Feat/injective perpetual offchain vaults
…to feat/injective_perpetual_with_delegation
Ran tests on Steps to reproduce:
Ran tests on
Note: Connector good to be approve once delegation script on testnet is fix. If dev note its a configuration issue, must will check again 🙇🏼 |
Hello @rapcmia, thank you for the comments. The error you are experiencing with testnet is due to a problem with the load balanced (lb) testnet nodes. I have added the possibility to use the |
PR update
Setup simple PERP-mm to check testnet using
Note:
Attached logs for reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Setup connector without the need of Gateway
- Account delegation script works for mainnet and testnet
- Testnet now has option to use "sentry"
- Connect wallet successful and balance shows assets of the granter
- Connect wallet to mainnet and testnet ok
- Setting up the connector defaults to mainnet settings and use must remove base on preference.
- Account configuration now has another option
read_account
, info available onREADME
- Setup simple PerpMM
- (mainnet) There are still noticeable issues found on mainnet similar to spot
- (testnet)
- Observe orders are successfully created and cancelled
- Also there are instances of network getting disconnected causing orders fetch failed but connector recovers after few minutes
- Not able to open and close position due to testnet markets but observed working just fine.
- Docker build ok
Note:
- Connector has been tested base on bronze standard and should work ok. Community can prcoeed with using the connector at ease else open a ticket and have injective team to look and fix.
…thub.com/aarmoa/hummingbot into feat/injective_perpetual_with_delegation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding the position to the missing places
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Implementation of a new Injective perpetual connector.
The new connector does not require Gateway (pure Python connector) and has been implemented to trade with delegated accounts (ie: the trading account trades in representation of a granter account, that is the one having the funds).
The PR also includes a refactoring to support MARKET orders in both the spot and perpetual connectors when using delegated accounts.
In order to use delegated accounts to trade it is necessary to perform a gran onchain. To send the grant transaction please use the script file
hummingbot/connector/exchange/injective_v2/account_delegation_script.py
.Tests performed by the developer:
Created unit tests for all new components.
Tested the connector by running perpetual market making strategies.
Tips for QA testing:
Configure a delegate trading account and test the connector using perpetual strategies.
PRP: https://snapshot.org/#/hbot-prp.eth/proposal/0x7caf486af6d79e38e60b41dd315ad103d437311c57b40386d122b6df373f776c