Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in rebalance order price #6527

Merged
merged 2 commits into from Aug 21, 2023

Conversation

rkc2000
Copy link
Contributor

@rkc2000 rkc2000 commented Aug 18, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Fixes the following issue in the fixed grid script:
#6523

There was in error in the calculation of order price for rebalance sell orders. This is corrected now.

Tests performed by the developer:

Tips for QA testing:

Copy link

@masimo12358 masimo12358 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be correct, as I recall the wrong rebalance order was indeed 1/100 of the current price.

@rapcmia rapcmia merged commit e385d52 into hummingbot:development Aug 21, 2023
2 checks passed
@rapcmia
Copy link
Contributor

rapcmia commented Aug 21, 2023

Merged to development and part of release version 1.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants