New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/XRPL connector v2 #6535
Feat/XRPL connector v2 #6535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes
hummingbot/connector/gateway/clob_spot/data_sources/xrpl/xrpl_utils.py
Outdated
Show resolved
Hide resolved
hummingbot/connector/gateway/clob_spot/data_sources/xrpl/xrpl_api_data_source.py
Outdated
Show resolved
Hide resolved
@mlguys Could you please resolve branch conflicts? |
hi @mlguys Could you please resolve branch conflicts? |
Hi @nikspz, sorry for the delay, conflicts resolved. |
@mlguys Could you please check unit tests failed (test coverage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:
- Setup gateway connection with Feat/XRPL connector v2 gateway#128
- Setup wallet using XRP testnet
wss://s.altnet.rippletest.net:51233
- Setup simple pmm on USD/VND
- Build docker image and run tests via docker compose ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged to development and part of release version 1.23.0 |
Hi @mlguys Please add docs for the connector to our docs site - https://github.com/hummingbot/hummingbot-site |
Thanks for the reminder @david-hummingbot, working on it! |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
gateway
USD/VND
andXRP/VND
marketsTips for QA testing: