Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/XRPL connector v2 #6535

Merged
merged 22 commits into from Dec 1, 2023

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented Aug 22, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Implemented CLOB api data source for XRPL Gateway connector
  • Added tests to test the api data source
  • Enable HB client to run strategies that support CLOB DEX connector, such as Pure Market Making strategy

Tests performed by the developer:

  • Added wallets and connected to XRPL chain using gateway
  • Checked balances on XRPL chain
  • Created and run PMM strategy on XRPL DEX, using USD/VND and XRP/VND markets

Tips for QA testing:

- USD/VND testnet book:
https://sologenic.org/trade?n[etwork=test](https://sologenic.org/trade?market=USD%2Brh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx%2FVND%2Brh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx)net&market=USD%2Brh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx%2FVND%2Brh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx

- XRP/VND testnet book:
https://sologenic.org/trade?n[etwork=](https://sologenic.org/trade?market=USD%2Brh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx%2FVND%2Brh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx)testnet&market=USD%2Brh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx%2FVND%2Brh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx
  • To trade on other markets, please contact me for how to do that as you will need to update connector config

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

@nikspz
Copy link
Contributor

nikspz commented Sep 15, 2023

@mlguys Could you please resolve branch conflicts?

@nikspz
Copy link
Contributor

nikspz commented Oct 2, 2023

hi @mlguys Could you please resolve branch conflicts?

@mlguys
Copy link
Contributor Author

mlguys commented Oct 3, 2023

Hi @nikspz, sorry for the delay, conflicts resolved.

@nikspz
Copy link
Contributor

nikspz commented Oct 4, 2023

@mlguys Could you please check unit tests failed (test coverage)

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

  • Setup gateway connection with Feat/XRPL connector v2 gateway#128
  • Setup wallet using XRP testnet wss://s.altnet.rippletest.net:51233
  • Setup simple pmm on USD/VND
    image
    • Orders are created and canceled successfully on set refresh time
    • Orders match on client and exchange
      image
    • Filled trade event
      • Login 2nd account to take the order of 1st account
      • Trade data on client and exchange match, excluding fees on history command
  • Build docker image and run tests via docker compose ✅

Copy link
Sponsor Contributor

@fengtality fengtality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapcmia rapcmia merged commit 0b26b58 into hummingbot:development Dec 1, 2023
2 checks passed
@rapcmia
Copy link
Contributor

rapcmia commented Dec 1, 2023

Merged to development and part of release version 1.23.0

@david-hummingbot
Copy link
Contributor

Hi @mlguys Please add docs for the connector to our docs site - https://github.com/hummingbot/hummingbot-site
You can use any of the Bronze connectors as a template. Thanks!

@mlguys
Copy link
Contributor Author

mlguys commented Dec 6, 2023

Thanks for the reminder @david-hummingbot, working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants