Feat/polkadex v2 #6558
Merged
Feat/polkadex v2 #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
PR update:
|
rapcmia
approved these changes
Aug 31, 2023
cardosofede
approved these changes
Sep 4, 2023
hummingbot/core/event/events.py
Outdated
| @@ -37,6 +37,8 @@ class MarketEvent(Enum): | |||
|
|
|||
| class OrderBookEvent(int, Enum): | |||
| TradeEvent = 901 | |||
| OrderBookDataSourceUpdateEvent = 904 | |||
| PublicTradeEvent = 905 | |||
There was a problem hiding this comment.
@petioptrv hey pet, the TradeEvent is actually the public trade event check that the order book is triggering it when a new trade arrives
There was a problem hiding this comment.
The idea here was to differentiate the "data-source" event from the event that the clients of the exchange connector want to consume, but I agree that, in this case, it's redundant. I'll make the change.
There was a problem hiding this comment.
Done, @rapcmia, the only part of the functionality that needs to be re-tested is that public trade events are being received by the bot
cardosofede
approved these changes
Sep 7, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR introduces an update to the Polkadex connector to use the V2 API.
Tests performed by the developer:
Tips for QA testing:
Note that every now and then, the periodic order status update may fail because it happened immediately after submitting an order. Since Polkadex is a decentralized exchange, it takes a couple of seconds for the order to make it onto the chain and to become available for order status updates.
[ch-43708]