New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/migrate to injective v08 #6565
Merged
cardosofede
merged 8 commits into
hummingbot:development
from
aarmoa:feat/migrate_to_injective_v08
Sep 15, 2023
Merged
Feat/migrate to injective v08 #6565
cardosofede
merged 8 commits into
hummingbot:development
from
aarmoa:feat/migrate_to_injective_v08
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctors to handle correclty order creation with price None or NaN (for market orders. Removed support for mainnet nodes other than the load balanced node.)
rapcmia
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Test on local mbp on both osx64 and arm64
- Ran account_delegate script on mainnet
- Issue on changing node has been fixed
- No errors observed and txn matched on the data used on script
- connect injective_v2 and injective_v2_perpetual
- Ran tests only for delegate_account
- Setup does not require change of node
- Setup simple PMM and PerpMM
- Error on mainnet now is fixed
- However not able to fully test due to QA test wallet
- If insufficient balance, it is displayed as well on the logs
- Build docker image and ran same steps, all ok
cardosofede
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @aarmoa good day |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
lb
node for mainnetTests performed by the developer:
All tests running in green.
The connector can be configured when running the client for the mainnet network.
Tips for QA testing: