Fix / Kujira / Adding support to multiple markets and market orders #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darley-silva-funttastic
force-pushed
the
fix/kujira/adding-multiple-markets-support
branch
from
475ce2c
to
87411b8
Compare
danilo-silva-funttastic
changed the title
danilo-silva-funttastic
changed the title
darley-silva-funttastic
force-pushed
the
fix/kujira/adding-multiple-markets-support
branch
from
87411b8
to
becff38
Compare
alvaro-mota-funttastic
force-pushed
the
fix/kujira/adding-multiple-markets-support
branch
from
becff38
to
ffd97fa
Compare
danilo-silva-funttastic
force-pushed
the
fix/kujira/adding-multiple-markets-support
branch
from
ffd97fa
to
fdb12ea
Compare
danilo-silva-funttastic
force-pushed
the
fix/kujira/adding-multiple-markets-support
branch
from
fdb12ea
to
aee2ecb
Compare
|
Hi @fengtality, @cardosofede, @rapcmia We've created this PR (and another one for the Gateway) in order to update and improve our connector due to some feedback we've received from our users. From the HB docs it seems we wouldn't need a PRP for PRs that doesn't require a bounty (but only opening it here), is that correct? As you can see the changes for this PR are relatively simply, only few files. Please kindly take a look at it when you have time. |
danilo-silva-funttastic
force-pushed
the
fix/kujira/adding-multiple-markets-support
branch
4 times, most recently
from
4445e00
to
1a0274e
Compare
danilo-silva-funttastic
force-pushed
the
fix/kujira/adding-multiple-markets-support
branch
5 times, most recently
from
1dea886
to
1eed3f7
Compare
commit b935385 Author: Danilo Araújo Silva <danilo.silva@funttastic.com> Date: Thu Oct 26 22:35:54 2023 +0300 Fixing unit test. commit bb74caf Author: Danilo Araújo Silva <danilo.silva@funttastic.com> Date: Wed Oct 25 23:04:55 2023 +0300 Improving support to multiple markets. commit 5cbcea1 Author: Álvaro E. F. Mota <alvaro.mota@funttastic.com> Date: Wed Oct 25 15:20:29 2023 -0300 Added command to ignore request with order.exchange_id equals None, Only call market_info clear if there is a market_info commit 87411b8 Author: Darley Araújo Silva <darley.silva@funttastic.com> Date: Thu Oct 19 16:47:14 2023 -0300 Adding support for OrderType.MARKET. commit 31f55a9 Author: Darley Araújo Silva <darley.silva@funttastic.com> Date: Thu Oct 19 16:47:02 2023 -0300 Adding support for multiple trading pairs instead of just one trading pair to the "get_account_balances()" and "_update_markets()" methods.
danilo-silva-funttastic
force-pushed
the
fix/kujira/adding-multiple-markets-support
branch
from
1eed3f7
to
1705813
Compare
fengtality
approved these changes
Nov 13, 2023
nikspz
approved these changes
Nov 13, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that strategies or scripts that use more than one market simultaneously, the methods "get_account_balances()" and "_update_markets()" have been updated to support multiple markets. This ensures those strategies, like Arbitrage, can be used.
Additionally, due to user demand for creating scripts that place market orders, support for the 'MARKET' order type has been added.
We also improved the code to avoid trying to update not yet created orders and then avoiding some warning or error messages that could happen.