New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/add_injective_v2_paper_trade_support #6684
feat/add_injective_v2_paper_trade_support #6684
Conversation
…ithub.com/aarmoa/hummingbot into feat/add_injective_v2_paper_trade_support
…GES and use the values from the Pydantic configuration
…to feat/add_injective_v2_paper_trade_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@aarmoa @rapcmia the poll already met the quorum, but I think that based on the nature of the PR we can merge it without the final approval time. What do you think @fengtality ? |
@aarmoa Could you please review this issue? Steps: Actual:
|
Sorry @nikspz, I did not receive a notification with your comment. I will take a look at the issue. |
…GES and use the values from the Pydantic configuration
…injective connector configured in the system
…ithub.com/aarmoa/hummingbot into feat/add_injective_v2_paper_trade_support
@nikspz please try again. I made some changes for paper trade to work also when there is no Injective V2 connector configured in the system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Cloned and installed feature branch
- Manually built docker image successfully
- Created/started pureMM using injective_v2_paperTrade successfully
- Created/started pureMM using binance successfully
- Created/started XEMM strategy using injective_v2_paperTrade and binance_paperTrade successfully
- Created/started avellaneda_market_making strategy using injective_v2_paperTrade
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR adds Injective V2 spot connector to the list of paper trade connectors.
Includes a refactoring to make the client configuration for paper trade connectors the only official list of paper trade connectors.
Tests performed by the developer:
All unit tests passing in green
Tips for QA testing:
PRP: https://snapshot.org/#/hbot-prp.eth/proposal/0xd74ce4c37dbc73a9379956c6f535117569cc95d09ff183cf52868b9ab1a568e9