New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/kraken market orders #6703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that also you need to adapt the test
elif order_type is OrderType.LIMIT_MAKER: | ||
order_type_str = 'LIMIT_MAKER' | ||
else: | ||
order_type_str = 'MAKER' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that Market is MAKER in kraken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch this should be MARKET
. It's just used in the log message below.
@@ -822,7 +822,7 @@ cdef class KrakenExchange(ExchangeBase): | |||
try: | |||
order_result = None | |||
order_decimal_amount = f"{decimal_amount:f}" | |||
if order_type is OrderType.LIMIT or order_type is OrderType.LIMIT_MAKER: | |||
if order_type is OrderType.LIMIT or order_type is OrderType.LIMIT_MAKER or order_type is OrderType.MARKET: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you can simplify (mainly if other types are added) with
if order_type in self.supported_order_types() that you added in line 777
Run the market order script here
|
@rapcmia I updated the Kraken connector - can you test it out, especially on V2 strategies (ie. Binanc/Kucoin candles + trading on Kraken) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Cloned and installed feature branch
- Ran Dman-v3 strategy using kraken and binance_perpetual as candles exchange
- Review bot failed to close orders with market orders (discussed to update later)
- Ran simple_order_example script on sell and buy, review market order was filled
- Created/start pureMM using kraken, review order fills not affected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request: