Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes infinite loop in start_mqtt_async - hummingbot/brokers/issues/8 #6704

Merged
merged 2 commits into from Dec 11, 2023

Conversation

klpanagi
Copy link
Contributor

@klpanagi klpanagi commented Dec 8, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Fixes errors produced while using the mqtt_autostart. Reported in: hummingbot/brokers/issues/8#issuecomment-1846971660

Tests performed by the developer:

Tested 2 Cases.

Case 1 - mqtt_autostart enabled on startup:

  • Broker is disconnected
  • Start the bot
  • Import a strategy
  • Start the strategy
  • Start the broker
  • Bot should connect successfully and without any disconnection logs

Case 2 - mqtt_autostart disabled on startup:

  • Broker is disconnected
  • Start the bot
  • Set the mqtt_autostart to True
  • Connect to broker
  • Import a strategy
  • Start the strategy
  • Start the broker
  • Bot should connect successfully and without any disconnection logs

And of course I have tested while the broker is running before starting the bot

Tips for QA testing:

@david-hummingbot david-hummingbot self-assigned this Dec 8, 2023
Copy link
Contributor

@david-hummingbot david-hummingbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Built Docker image and tested using Dashboard
  • Master Bot is able to reconnect without restarting container when broker is started

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rapcmia rapcmia merged commit ec9dec5 into hummingbot:development Dec 11, 2023
2 checks passed
@rapcmia
Copy link
Contributor

rapcmia commented Dec 11, 2023

Merged to development and part of release version 1.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants