New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/advanced market making #6742
Merged
rapcmia
merged 30 commits into
hummingbot:development
from
cardosofede:feat/advanced_market_making
Jan 5, 2024
Merged
Feat/advanced market making #6742
rapcmia
merged 30 commits into
hummingbot:development
from
cardosofede:feat/advanced_market_making
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- returning balance command reqs to UserBalances class to it's original format. - Changed logic of UserBalance funcs used by balance command to only report for non-gateway exchanges
|
rapcmia
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Ran tests using
v2_market-making_dman_v4_multiple_pairs.py
usingbinance perpetual
- Review log file of bot with runtime of 20hrs
- No error found, position are successfully closed
- Position executors are completed with close types EARLY_STOP and TIME_LIMIT
- Review sqlite PositionExecutor table, data for closeType matched from the logs
- No stuck orders upon stop command
- Ran as well multiple market pairs with same order level 3 with runtime of 8hrs
- No error found, position are successfully closed
- Position executors are completed with close types EARLY_STOP
- Review sqlite PositionExecutor table, data for closeType matched from the logs
- No stuck orders upon stop command
- Built docker image, ok
Merged to development and part of release version 1.24.0 |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Add advanced market making feature that includes global trailing stop
Tests performed by the developer:
Tips for QA testing: