New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/simplify funding loop #6749
Conversation
@MementoRC thanks for this work memento! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Funding payment for the following connectors has been monitored and observed ok
- Binance perpetual
- Gateio perpetual
- Kucoin perpetual
- dYdX perpetual
@cardosofede The Condition adds a lock to the Event. It could be used to prevent the apparent race condition that occurred. |
@MementoRC I think that we should go with this PR. Please clean the test that are commented and we are ready to go |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This is to try to understand what is wrong with this PR from fede
Tests performed by the developer:
Tips for QA testing: