New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/injective chain streams #6760
Feat/injective chain streams #6760
Conversation
…moa/hummingbot into feat/injective_chain_streams
…to feat/injective_chain_streams
…D (client order ID) to create orders, cancel orders and process their updates
…to feat/injective_chain_streams
…ive SDK version in the dependencies
… order id) if it is already available to cancel orders (to make the new connector backwards compatible)
…ective Indexer, to much the ids of the trades received through the chain stream
…onnectors. Updated unit tests to work correctly after the refactoring.
…to feat/injective_chain_streams
…to feat/injective_chain_streams
…d in chain streams, and start using again the tradeId with the trades provided by the Indexer
…to feat/injective_chain_streams
…onnectors to start using the new TradesV2 logic in the indexer
…to feat/injective_chain_streams
… (they are updates and not snapshots)
I have just pushed a fix for the orderbooks updates processing. For some reason GitHub is not reflecting it in the PR yet, but please consider that the last commit you should see before testing is |
…trigger the order creation event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Cloned and installed feature branch
- Manually built docker image successfully
- connected injective_v2 and injective_v2_perpetual using testnet and delegate_acount successfully
- checked balance successfully
- created second account to balance order book manually
- Created/started pureMM using injective_v2 on testnet helix app successfully
- review orders placing/refresh/filled, recorded in CSV data
- Created/started perpetualMM using injective_v2_perpetual on testnet helix app successfully
- review orders to OPEN placing/refreshed succesfully
- orders to CLOSE placed/filled according to the config params set
Note: need to fix failing tests on this PR
Hello @nikspz. Thank you for taking the time to review the PR. |
…to feat/injective_chain_streams
…moa/hummingbot into feat/injective_chain_streams
A clean installation prevents the error below, as pointed out by @david-hummingbot. I'm keeping the message in case someone needs it.Trying to compile and start from the source at v1.24.0 prints out this error:
Important part: I think it's relevant to this pull request. I also tested building from source at v1.23.0, and it works fine. |
@0xferit You'll need to do a full uninstall, remove the hummingbot conda environment and then run install and compile again. |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
injective-py
dependency to point to the version required to interact with Injective mainnet after the chain upgrade taking place on January 11th.Tests performed by the developer:
testnet
.Tips for QA testing:
mainnet
this PR should be only tested usingtestnet