Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) fixed directional script bugs and added configurable pmm script #6785

Merged
merged 5 commits into from Jan 19, 2024

Conversation

fengtality
Copy link
Sponsor Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Fixes bugs in sample V2 configurable scripts
  • Adds configurable simple PMM script

This is a work in progress PR. The final version should clean up the sample scripts folder and make them all configurable.

Screen Shot 2024-01-16 at 12 27 49 PM

@fengtality fengtality marked this pull request as ready for review January 17, 2024 00:06
Copy link
Contributor

@david-hummingbot david-hummingbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order_amount: str = Field("0.01",

I think this should be decimal instead of string?

@fengtality fengtality merged commit 4946f21 into development Jan 19, 2024
2 checks passed
@fengtality fengtality deleted the fix/more-config-scripts branch January 19, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants