Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unexpected_error_while_processing_event_201 #6789

Conversation

yancong001
Copy link
Contributor

@yancong001 yancong001 commented Jan 17, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

@rapcmia rapcmia self-requested a review January 18, 2024 03:20
Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ran tests using perpetual market making
  • Ran tests using multiple order levels of 3
  • Runtime of 7hrs and review logs
    • No error related to unexpected_error_while_processing_event_201
    • Found reduce orders but not related to PR
    • No tests done for v2 strategy (will be tested when merged to development)
  • Build docker image ok

@rapcmia
Copy link
Contributor

rapcmia commented Jan 18, 2024

Hi @yancong001 good day,
PR has been approved however we have failing tests on Github. When available, please have a look thank you

@cardosofede
Copy link
Contributor

@yancong001 that method is specific when dealing with dex? seems like trying to raise the error will always raise the error why we are doing this? btw, the coverage needs 1 more line covered

@yancong001
Copy link
Contributor Author

Sometimes exchange_id is received slowly after place_order. In this case, querying active_order raises KeyError.

The parent class “_update_lost_orders_status” method uses the deprecated "_all_trade_updates_for_order" method, so the ”_update_lost_orders_status“ method is redeclared here.

new unittest added.

@rapcmia rapcmia merged commit 3057732 into hummingbot:development Jan 19, 2024
2 checks passed
@rapcmia
Copy link
Contributor

rapcmia commented Jan 19, 2024

Merged to development and part of release version 1.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants