Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/ rename Huobi to HTX #6796

Merged
merged 24 commits into from Feb 5, 2024
Merged

Refactor/ rename Huobi to HTX #6796

merged 24 commits into from Feb 5, 2024

Conversation

blagodar1
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

cardosofede
cardosofede requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only revert the flake 8 change that you made and review that the endpoints are not changing.

.flake8 Outdated Show resolved Hide resolved
hummingbot/connector/exchange/htx/htx_auth.py Show resolved Hide resolved
cardosofede
cardosofede requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only revert the flake 8 change that you made and review that the endpoints are not changing.

@cardosofede
Copy link
Contributor

@nikspz try to run a strategy in HTX too

@nikspz
Copy link
Contributor

nikspz commented Jan 30, 2024 •
edited

Test performed:

  • Cloned and installed PR6796
  • Connected HTX successfully
  • checked balance successfully
  • Created/started pureMM using htx with no issues
  • Checked status and order_book succesfully update in --live
  • Review filled orders events handled succesfully, in Client/exchange matched

Need to fix failing tests

@notion-workspace Notion Workspace
Copy link

Refactor/ rename Huobi to HTX

cardosofede
cardosofede approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cardosofede cardosofede merged commit c0f9390 into hummingbot:development Feb 5, 2024
2 checks passed
@nikspz nikspz mentioned this pull request Feb 26, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardosofede cardosofede cardosofede approved these changes

@nikspz nikspz nikspz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blagodar1 @cardosofede @nikspz