Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Increase update interval for XRPL + Make Rate Oracle work with not supported pairs #6855

Merged
merged 7 commits into from Feb 20, 2024

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented Feb 18, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Increased snapshot update interval so that it will not rate limit official XRPL nodes
  • Add set_price method to rate oracle so that we can update price of pair that is not available on available rate oracles (binance, kucoin, coincap, etc.)

Tests performed by the developer:

  • Run PMM strategy on SOLO/XRP
  • Run sample scripts:
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_format_status.py
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_simple_arbitrage.py
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_simple_pmm.py
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_simple_rsi.py
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_simple_xemm.py

Tips for QA testing:

@mlguys mlguys changed the title Fix/Increase update interval for snapshots Fix/Increase update interval for XRPL + Make Rate Oracle work with not supported pairs Feb 19, 2024
Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengtality fengtality merged commit 84b4f9c into development Feb 20, 2024
2 checks passed
@fengtality fengtality deleted the fix/xrpl-increase-snapshot-update-interval branch February 20, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants