-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/xemm executor #6946
Merged
rapcmia
merged 73 commits into
hummingbot:development
from
cardosofede:feat/xemm_executor
Apr 22, 2024
Merged
Feat/xemm executor #6946
rapcmia
merged 73 commits into
hummingbot:development
from
cardosofede:feat/xemm_executor
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with trade update
PR update on commit
|
rapcmia
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Setup controller config generic.xemm_multiple_levels.py
- Ran tests on Kucoin, Okx and Binance spot connectors
- Maker connector create limit order, taker connector create market order
- When Maker and Taker orders are completed, executor terminated
- When target profitability is below min_profitability, order is canceled
- When target profitability is above max_profitability, order is canceled
- When target profitability is between min and max, order stays active ✅
- Ran long term bots and observe behavior
- User must always check inventory, when not enough balance script would return "Not enough budget to open position"
- When the target profitability rate is tight, connector tends to create and cancel order after 5-10s resulting large log files
- Trade data between CSV, history and exchange trade history match
- Multiple order levels are supported
- Observe partial fills on tests and works ok on script
- Build docker image ok
Merged to development and part of release version 1.27.0 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: