-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new api update from binance #6986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Clone and install PR6986
- connect binance successfully
- check API keys connected successfully
- checked balance successfully
- created/started pureMM using binance successfully
- review on exchange UI, orders placed
- status --live: ok
- order cancellation: ok
- orders filled: ok
- History --verbose: ok
- Trade fees compared with exchange: ok
- Data aggregation on datadog according to Client and exchange: ok
Hey @nikspz , since I disabled the rate oracle for Binance US from Binance code, I added new code to finally split them apart as separated Rate Oracle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@cardosofede, @nikspz Was this tested against Binance.US? I am getting the same errors as the original issue: 2024-04-30 14:52:05,902 - 63999 - hummingbot.connector.exchange.binance.binance_api_order_book_data_source.BinanceAPIOrderBookDataSource - ERROR - Unexpected error occurred subscribing to order book trading and delta streams... I am running the latest code from the master branch. Thanks! |
Thanks for the report, we'll try to check if related |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: