Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new api update from binance #6986

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented Apr 25, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

  • Run PMM
  • Run Balance command

Tips for QA testing:

@mlguys mlguys marked this pull request as ready for review April 25, 2024 09:47
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Clone and install PR6986
  • connect binance successfully
  • check API keys connected successfully
  • checked balance successfully
  • created/started pureMM using binance successfully
  • review on exchange UI, orders placed
  • status --live: ok
  • order cancellation: ok
  • orders filled: ok
  • History --verbose: ok
  • Trade fees compared with exchange: ok
  • Data aggregation on datadog according to Client and exchange: ok
    image

@mlguys mlguys mentioned this pull request Apr 25, 2024
2 tasks
@mlguys
Copy link
Contributor Author

mlguys commented Apr 25, 2024

Hey @nikspz , since I disabled the rate oracle for Binance US from Binance code, I added new code to finally split them apart as separated Rate Oracle.

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cardosofede cardosofede merged commit 119e630 into development Apr 25, 2024
2 checks passed
@cardosofede cardosofede deleted the fix/binance-api-update branch April 25, 2024 12:54
@mmarooney
Copy link

@cardosofede, @nikspz Was this tested against Binance.US? I am getting the same errors as the original issue:

2024-04-30 14:52:05,902 - 63999 - hummingbot.connector.exchange.binance.binance_api_order_book_data_source.BinanceAPIOrderBookDataSource - ERROR - Unexpected error occurred subscribing to order book trading and delta streams...
Traceback (most recent call last):
File "/hummingbot/hummingbot/connector/exchange/binance/binance_api_order_book_data_source.py", line 75, in _subscribe_channels
symbol = await self._connector.exchange_symbol_associated_to_pair(trading_pair=trading_pair)
File "hummingbot/connector/exchange_base.pyx", line 97, in exchange_symbol_associated_to_pair
return symbol_map.inverse[trading_pair]
File "//miniconda3/envs/hummingbot/lib/python3.10/site-packages/bidict/_base.py", line 524, in getitem
return self._fwdm[key]
KeyError: 'BTC-USDT'

I am running the latest code from the master branch.

Thanks!

@nikspz
Copy link
Contributor

nikspz commented Apr 30, 2024

I am getting the same errors as the original issue on Binance.US :

2024-04-30 14:52:05,902 - 63999 - hummingbot.connector.exchange.binance.binance_api_order_book_data_source.BinanceAPIOrderBookDataSource - ERROR - Unexpected error occurred subscribing to order book trading and delta streams... Traceback (most recent call last): File "/hummingbot/hummingbot/connector/exchange/binance/binance_api_order_book_data_source.py", line 75, in _subscribe_channels symbol = await self._connector.exchange_symbol_associated_to_pair(trading_pair=trading_pair) File "hummingbot/connector/exchange_base.pyx", line 97, in exchange_symbol_associated_to_pair return symbol_map.inverse[trading_pair] File "//miniconda3/envs/hummingbot/lib/python3.10/site-packages/bidict/_base.py", line 524, in getitem return self._fwdm[key] KeyError: 'BTC-USDT'

I am running the latest code from the master branch.

Thanks for the report, we'll try to check if related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Release version 1.27.0
Development

Successfully merging this pull request may close these issues.

None yet

4 participants