-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/kucoin exchange id is none #6999
Fix/kucoin exchange id is none #6999
Conversation
I've made some research checking other connectors standards, and this is the most suitable implementation for this bug. If there is an unexpected behaviour or you think there is a better approach to this issue, please feel free to write it down here! |
1 similar comment
PR update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Ran test on XEMM controller config and XEMM script config, all ok
- Ran for 3-4hours with spreads enough to trigger opportunity for trade
- Ran tests on different markets and LOOM-USDT
- Review logs, not found keyError:data nor exchange_order_id=NaN
- Do steps to reproduced by Vik from Kucoin lost order error #6968 using simple_pmm_example.py
- Compare this PR and Development branch
- Observed that there is a active order on development but not on this PR, therefore issue is fix
- Ran for 15-30mins, all ok
- Do tests where base or quote asset is 0 balance and start v2 strategy
- On Development, able to reproduce but not on this PR
- Ran dman_maker_v2 on this tests and all ok, no active order on both client and exchange
- Build docker image ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
coverage run --source=hummingbot/connector/exchange/kucoin -m nose test/hummingbot/connector/exchange/kucoin/test_kucoin_exchange.py && coverage report --include="*/kucoin_exchange.py" -m
Tips for QA testing:
start --script v2_xemm.py --conf debugging_script.yml
, being debugging_script.yml