Figure out how to "upload" resources to GitHub #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batunpc
requested changes
Nov 15, 2022
github-upload.js
Outdated
| @@ -0,0 +1,27 @@ | |||
| import { Octokit, App } from "https://cdn.skypack.dev/octokit?dts"; | |||
There was a problem hiding this comment.
App does not need to be imported
github-upload.js
Outdated
| }) | ||
| } | ||
|
|
||
| window.githubUpload = githubUpload |
There was a problem hiding this comment.
This line seems redundant.
CDPhu
requested changes
Nov 15, 2022
github-upload.js
Outdated
| @@ -0,0 +1,27 @@ | |||
| import { Octokit, App } from "https://cdn.skypack.dev/octokit?dts"; | |||
There was a problem hiding this comment.
Would it not be better practice to import Octokit via node_modules? I get that this works, but apparently importing from HTTP is still experimental.
https://nodejs.org/api/esm.html#https-and-http-imports
There was a problem hiding this comment.
Since my file was pretty small, I did it this way. I am not sure if there are any restrictions.
|
@saminarp Given that you coded the functions elegantly, I did not want to point out that |
|
I have updated my implementation, let me know how it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
I have done my implementation based on PRs created for #1 and #4
Please review and let me know if this is the right approach. Feel free to review and request for changes.