Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How is this component secure? The app secret is required in the component? #113

Closed
princefishthrower opened this issue May 30, 2022 · 1 comment
Closed

How is this component secure? The app secret is required in the component? #113

princefishthrower opened this issue May 30, 2022 · 1 comment

Comments

@princefishthrower
Copy link

princefishthrower commented May 30, 2022 •
edited
Loading

Hi all,

I'm wondering how this component / login flow is secure, as it requires the app secret directly as a prop. Shouldn't the app secret be referenced and used only in a server-like environment?

Interested to hear anybody's thoughts on this.

Cheers,

Chris
@princefishthrower
Copy link
Author

My bad, I now see the discussion: #54 and the corresponding documentation in the README. However, this should be the default implementation. (app secret should not even be implemented as a prop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@princefishthrower