Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing secret on the client side is bad practice #54

Closed
fniewijk opened this issue Nov 29, 2019 · 6 comments
Closed

Exposing secret on the client side is bad practice #54

fniewijk opened this issue Nov 29, 2019 · 6 comments

Comments

@fniewijk
Copy link

I was looking at using your package, but when I read your code and compare it with the manual it says that you should not share the app_secret client side. It suggests you should use the client side implicit authentication. link

Are you aware of this? This looks like an issue that is resolvable. The implicit authentication does not need the secret.

@fniewijk fniewijk changed the title Exposing client_id secret on the client side is bad practice Exposing secret on the client side is bad practice Nov 29, 2019
@gitstud
Copy link

gitstud commented Feb 7, 2020

The docs here show where to put the app secret but not where to get it, you can serve the app secret from your server and then connect it with however you manage state

@codeundercoverdev
Copy link

@gitstud @fniewijk doesn't that still expose the app secret to the user when you fetch it from your server?

@victor871129
Copy link

@gitstud @fniewijk doesn't that still expose the app secret to the user when you fetch it from your server?

Yes, that's why you need to check the integrity of your app with a Tampering Detection solution and only store the secret on the phone RAM

@chr4ss1
Copy link

chr4ss1 commented May 30, 2020

yeah, this is a bit design flaw in this lib, there should never be appSecret exposed anywhere on the JS side, memory or no memory.

it is working for me with responseType=code, and appSecret="completelyrandomNONVALID".

Looks like IG does not use it:

https://developers.facebook.com/docs/instagram-basic-display-api/guides/getting-access-tokens-and-permissions

@hungdev
Copy link
Owner

hungdev commented Jun 8, 2020

I added an option for expose secret, read doc here

@jaweherncir
Copy link

Hello please some hir con help me to get the profil photo of Facebook account with nodejs please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants