Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix incoherent bounds seidel lp 1d #247

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Bugfix incoherent bounds seidel lp 1d #247

wants to merge 3 commits into from
+46 −17

Conversation

mskripnik
Copy link

Fixes #244 and #245

Changes in this PRs:

  • Prevent a problem becoming infeasible due to numerical errors by extending the lower and upper bounds if they are very close.
  • Explicitly call std::vector constructor to avoid ambiguity when providing initializer list to BoundaryCond.

Checklists:

  • Update HISTORY.md with a single line describing this PR

@hungpham2511
Copy link
Owner

Hi, thanks for the PR. Let me get back to you real soon.

@mskripnik
Copy link
Author

mskripnik commented Apr 18, 2024 •
edited
Loading

Hi, thanks for the PR. Let me get back to you real soon.

Any update? The python jobs were failing but I don't know why. I haven't touched anything python related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seidel LP 1D: incoherent bounds
2 participants
@mskripnik @hungpham2511