Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel Overflow on Main page #12

Closed
jitinder opened this issue Jun 20, 2020 · 3 comments · Fixed by #21
Closed

Pixel Overflow on Main page #12

jitinder opened this issue Jun 20, 2020 · 3 comments · Fixed by #21

Comments

@jitinder
Copy link
Contributor

pokedex

Model: OnePlus 5

Can be fixed using MediaQuery instead of specifying raw values to height.
@hungps
Copy link
Owner

hungps commented Jun 20, 2020

Actually it's currently using MediaQuery to calculate the height. But it seems broke in some small devices. I will check and increase the size a little bit so it can work well on OnePlus 5

hungps added a commit that referenced this issue Jul 14, 2020
@hungps
resolve #12
de7d5f3
@hungps hungps mentioned this issue Jul 14, 2020
Merged
@hungps
Copy link
Owner

hungps commented Jul 14, 2020 •
edited
Loading

Hi @jitinder,
Pull request #21 should fix this issue. Please re-check it. Feel free to reopen it if this issue still exists.

@jitinder
Copy link
Contributor Author

@scitbiz The issue has been resolved. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update home screen spacing hungps/flutter_pokedex
2 participants
@jitinder @hungps