Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for type weaknesses #14

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Add support for type weaknesses #14

merged 2 commits into from
Jun 21, 2020

Conversation

jitinder
Copy link
Contributor

pokedex

Added some code that shows type weaknesses for each pokemon. Also expanded on some existing widgets to allow for this functionality.

lib/data/pokemons.dart Outdated Show resolved Hide resolved
lib/models/type.dart Outdated Show resolved Hide resolved
lib/screens/pokemon_info/widgets/tab_base_stats.dart Outdated Show resolved Hide resolved
lib/models/type.dart Outdated Show resolved Hide resolved
lib/data/types.dart Outdated Show resolved Hide resolved
lib/screens/pokemon_info/widgets/tab_base_stats.dart Outdated Show resolved Hide resolved
lib/screens/pokemon_info/widgets/tab_base_stats.dart Outdated Show resolved Hide resolved
lib/screens/pokemon_info/widgets/tab_base_stats.dart Outdated Show resolved Hide resolved
lib/screens/pokemon_info/widgets/tab_base_stats.dart Outdated Show resolved Hide resolved
lib/widgets/pokemon_type.dart Outdated Show resolved Hide resolved
@hungps
Copy link
Owner

hungps commented Jun 20, 2020

Also, don't forget to format your code using dartfmt and use single-quote instead of double-quote

@jitinder
Copy link
Contributor Author

Made the changes, let me know if there's anything else missing :D

@hungps
Copy link
Owner

hungps commented Jun 21, 2020

Looking great. Thank you!

@hungps hungps merged commit e9bcc4c into hungps:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants