-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
works on chrome and macos #73
works on chrome and macos #73
Conversation
The https://assets.pokemon.com/ is returning a CORS issue but the app does run now. Also sorry for the super long PR |
Uhhh, very good! 🚀 |
@felipecastrosales I kept seeing these can I do it and no one did it, so I thought I just would |
I'm updating my work environments so I'm gonna take a while to check this PR. I saw some theme changes on the code. |
@hugovidafe I haven't tried the code yet, but likely the theme changes come from Flutter 3.7.0. Or not? |
Idk, I didn't follow the Flutter change logs. When I already have the updated environment, I will catch up with the news. |
@Jesse-Lucas1996 @hugovidafe LGTM! If anyone can take some screenshots of the app running on the window, that would be great! |
@hungps I sure can do that for you :) if you have discord or something or even talk here it'll be great to figure out that image source as well |
@hugovidafe |
@Jesse-Lucas1996 |
@hungps have updated with pictures |
@Jesse-Lucas1996 Agree! Responsive is required. We could limit the width of the app for now so that the layout won't break. |
@hungps I'm all or installing random things and pray that it works, should we merge this PR in then try that? |
@Jesse-Lucas1996 Merged! |
Running on Windows 11:
imo the icons are a bit too large on windows?
we are getting a pixel overflow
Running on Chrome: