-
Notifications
You must be signed in to change notification settings - Fork 8
error when registering custom shape #24
Comments
I agree with @SebGo I have the same isse, the shape constructor is expected by the |
@hungtcs I am preparing a Pull Request for this. About the constructor parameters types, I will use [UPDATE]: mxShape constructor is |
Thanks for your solution @SebGo , I have encountered the same problem these days, but I didn't find the perfect way. |
Previous signature prevented to pass the shape constructor as the 2nd parameter. Closes hungtcs#24
Hi,
Thank you for the work you do in this repo.
I'm trying to implement a custom shape by extending mxActor.
When registering the Shape I get following error:
Argument of type 'typeof MyShape' is not assignable to parameter of type 'typeof mxShape'.
I think a solution could be to change registerShape() in mxCellRenderer.d.ts from
static registerShape(key: string, shape: typeof mxShape): void;
tostatic registerShape(key: string, shape: new (...args: any) => mxShape): void;
The text was updated successfully, but these errors were encountered: