Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of atypes.hxx prevents Hunspell::spell()'s info parameter from being used #432

Closed
rakuco opened this issue Nov 26, 2016 · 8 comments
Closed
Labels
Milestone

Comments

@rakuco
Copy link

rakuco commented Nov 26, 2016

With 1.5.0, atypes.hxx is no longer installed and hunspell.hxx does not include it, it is not possible to use the SPELL_* macros to check Hunspell::spell()'s info parameter.

Is this an oversight? If not, how should callers check info's value?

@dimztimz
Copy link
Contributor

I see. Maybe it should be fixed in v1.5.1. Can you provide a patch. Fixes for 1.5 go to branch ver1-5.

@dimztimz
Copy link
Contributor

Looking at the source of the command line tool, i see it manually includes atypes.hxx. Maybe that is a better option?

@rakuco
Copy link
Author

rakuco commented Nov 26, 2016

Maybe that is a better option?

I don't follow. The command line tool includes the header because it's part of the same tarball/checkout. That header is not installed into the system when packaging hunspell though, so users of the API cannot include it at all.

@dimztimz
Copy link
Contributor

That is if you use hunspell via package manager and hunspell.hxx is the only available include?

Also can you tell me what macros exactly are needed the public api?

@rakuco
Copy link
Author

rakuco commented Nov 27, 2016

That is if you use hunspell via package manager and hunspell.hxx is the only available include?

Correct (although a few other headers are also installed). This is a consequence of @caolanm's commit 99675e7.

Also can you tell me what macros exactly are needed the public api?

The API documentation for Hunspell::spell() only mentions SPELL_COMPOUND and SPELL_FORBIDDEN, but the implementation seems to use a few other SPELL_* macros as well.

@dimztimz
Copy link
Contributor

Please test the latest commit in branch ver1-5.

@dimztimz
Copy link
Contributor

dimztimz commented Nov 27, 2016

I released v1.5.1 and hopefully there should be no problems. Please test and close if resolved.

@rakuco
Copy link
Author

rakuco commented Nov 27, 2016

Thanks, I can confirm it's working fine (I was trying to build LyX with 1.5).

@rakuco rakuco closed this as completed Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants