Make hunspell look in XDG_DATA_DIRS for dictionaries #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dictionaries may exist but only show up under XDG_DATA_DIRS. For instance, $HOME/.local/share/hunspell could contain some dictionaries. This patch adds each directory in the hunspell subdir of each XDG_DATA_DIRS to the lookup path.
jtojnar
reviewed
Jul 22, 2022
| @@ -2044,6 +2044,13 @@ int main(int argc, char** argv) { | |||
| if (getenv("DICPATH")) { | |||
| path_std_str.append(getenv("DICPATH")).append(PATHSEP); | |||
| } | |||
| if (getenv("XDG_DATA_DIRS")) { | |||
There was a problem hiding this comment.
While at it, the basedir spec should probably be followed to the point (also support XDG_DATA_HOME and fall back to $HOME/.local/share and /usr/local/share/:/usr/share/ respectively).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dictionaries may exist but only show up under XDG_DATA_DIRS. For
instance, $HOME/.local/share/hunspell could contain some dictionaries.
This patch adds each directory in the hunspell subdir of each
XDG_DATA_DIRS to the lookup path.