We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The following patch resolves the warnings:
diff --git a/3rdparty/mythes/1.2.5/mythes.cxx b/3rdparty/mythes/1.2.5/mythes.cxx index ecf526e..b03799f 100644 --- a/3rdparty/mythes/1.2.5/mythes.cxx +++ b/3rdparty/mythes/1.2.5/mythes.cxx @@ -48,7 +48,8 @@ int MyThes::thInitialize(const char* idxpath, const char* datpath) readLine(pifile,wrd,MAX_WD_LEN); int idxsz = atoi(wrd); - if (idxsz <= 0 || idxsz > std::numeric_limits<int>::max() / sizeof(char*)) { + // spitz: fix -Wsign-compare warning + if (idxsz <= 0 || static_cast<unsigned int>(idxsz) > std::numeric_limits<int>::max() / sizeof(char*)) { fprintf(stderr,"Error - bad index %d\n", idxsz); fclose(pifile); return 0; @@ -176,7 +177,8 @@ int MyThes::Lookup(const char * pText, int len, mentry** pme) return 0; } int nmeanings = atoi(buf+np+1); - if (nmeanings < 0 || nmeanings > std::numeric_limits<int>::max() / sizeof(mentry)) + // spitz: fix -Wsign-compare warning + if (nmeanings < 0 || static_cast<unsigned int>(nmeanings) > std::numeric_limits<int>::max() / sizeof(mentry)) nmeanings = 0; *pme = (mentry*)(nmeanings ? malloc(nmeanings * sizeof(mentry)) : NULL); if (!(*pme)) {
The text was updated successfully, but these errors were encountered:
Two -Wsign-compare warnings in mythes.cxx #3
8f126c3
to solve #3
No branches or pull requests
The following patch resolves the warnings:
The text was updated successfully, but these errors were encountered: