-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIFA 18 support #1
base: fifa18
Are you sure you want to change the base?
Conversation
only one login flow is necessary since both the app and the website use the same code and authentication mechanism. Probably should give an option to use email as 2 factor mechanism as well.
no longer needed in favor of mobile-login.js
@Mardaneus86, thank you for taking the time to look at this initially. I'll try to test this myself tonight, but one warning is that EA added a few new API calls (pinEvents being one) which they may use for flagging accounts. We will also need to update the version in the URLs. |
Yeah I know, this is an early stab at the project. Just changed the URL's to version 18. ReturningUserYear should be last year, so that one is 2017. We should indeed incorporate the pinEvents call, and make sure the fifa-autobuyer project uses that call in the same way as the web app does. As far as I can tell from other projects, it has been around since FIFA 2016 (see trydis/FIFA-Ultimate-Team-Toolkit#201 for example). I'll try to find why and how the pinEvents call is used in the web app exactly, based on the source code. |
@Mardaneus86 - Now that the webapp is not a flash application, I'm thinking of just loading it directly and inject the additional functionality for the AB. I see you have some TamperMonkey scripts in your repo, is that something you would be interested in helping with? My initial thought was to just build a chrome extension, but since it is against ToS, it can be removed from the chrome store quickly. I built a proof of concept loading it in with Electron that we can go off of last night. The problem with that is it would be solely for the AB and not just an API people can write custom scripts for (initially). |
Well I was thinking nearly the same thing. I wanted to try to load your autobuyer functionality with Tampermonkey like I built my initial autobuyer. I would only need to replace the api calls and storage calls with Tampermonkey calls so it can work in the browser. This way it can’t be removed from the store and is usable across multiple browsers. I’ve done an initial test to load a React app when you click the autobuyer menu button in the web app and got that working. Will try some more later today. But you are right that it would veer of the api path that way. I’ll create an issue and branch on my repository to keep track of progress. |
Only one login flow is necessary since both the app and the website use the same code and authentication mechanism. Probably should give an option to use email as 2 factor mechanism as well. Currently only the App Authenticator is used, but can easily be changed.
login.js
became obsolete in favor ofmobile-login.js
.