Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added focal standard deviation filter #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mwip
Copy link

@mwip mwip commented Feb 12, 2019

I missed a standard deviation filter. The raster::focal version is not usable at all for large data sets.

@codecov-io
Copy link

codecov-io commented Feb 12, 2019

Codecov Report

Merging #38 into master will decrease coverage by 4.9%.
The diff coverage is 1.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   50.02%   45.12%   -4.91%     
==========================================
  Files          21       23       +2     
  Lines        1765     1724      -41     
==========================================
- Hits          883      778     -105     
- Misses        882      946      +64
Impacted Files Coverage Δ
R/velox_focal.R 0% <0%> (ø) ⬆️
src/stddev.cpp 0% <0%> (ø)
src/integral.cpp 1.12% <1.12%> (ø)
src/focal.cpp 1.12% <4.76%> (-0.33%) ⬇️
R/velox_rasterize.R 73.91% <0%> (-3.14%) ⬇️
R/velox_cast.R 55.26% <0%> (-2.88%) ⬇️
R/velox_extract.R 51.7% <0%> (-1.84%) ⬇️
R/velox.R 85.1% <0%> (-1.43%) ⬇️
R/boostgeom.R 53.57% <0%> (-0.82%) ⬇️
R/velox_aggregate.R 0% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7bc3c...afd8efe. Read the comment docs.

@mwip
Copy link
Author

mwip commented Feb 13, 2019

What does this even mean? I never changed the respective source files. Please let me know, if this poses any issues to the merge and how to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants