Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_1p #11

Open
huonw opened this issue Jan 13, 2019 · 0 comments
Open

log_1p #11

huonw opened this issue Jan 13, 2019 · 0 comments
Assignees
@huonw

Comments

@huonw
Copy link
Owner

huonw commented Jan 13, 2019 •
edited

Potentially best implemented in the form of log2_1p, but ln_1p should be exposed too.
@huonw huonw mentioned this issue Jan 13, 2019
Open
8 tasks
@huonw huonw self-assigned this Jan 22, 2019
@huonw huonw mentioned this issue Jan 26, 2019
Open
3 tasks
huonw added a commit that referenced this issue Jan 26, 2019
@huonw
Implement log2_1p.
4453c8e 
This switches between the linear approximation log_B(x) ~ x/ln(B) for
small x and the "obvious" log_B(1 + x), with the size threshold chosen
by `optimizer`. There was not much value in optimizing the
multiplicative constant (especially true for `ln_1p` if that is every
implemented: ln(x) ~ x avoids a multiplication), or using a
higher-degree polynomial, because the equation above is as accurate as
the `log2` approximation.

Fixes #11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huonw huonw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huonw