feat: auto clean dist folder before build

[nnecec]

Implement the feature #358 (comment). Here are changes:

1. add cleanBuildOutputDir before runBundle
2. add cleanDir in utils.ts
3. fix compile.test.ts. Because output dir will be clean at each bundle, we need run tests after finish bundle immediately.
4. When I run git commit , here is a hint hint: The '.husky/pre-commit' hook was ignored because it's not set as executable. I found a solution hook was ignored because it's not set as executable typicode/husky#1177. After I executed chmod ug+x .husky/*, the pre-commit file has been update.

[huozhi]

Can we keep this as its before? I want two bundle() calls finished then compare so the output are all there to check instead of bailing first

[nnecec]

It will clean the dist directory when executing the bundle function. So, if we keep this as before, I think we need to provide a new option in BundleConfig, or even support a new cli arg like --clean or --noClean, so that we can specify whether the dist needs to be deleted when the bundle is executed.

[nnecec]

Do you have any suggestions?

[huozhi]

Good call, we can clean by default, and add one more--no-clean arg for not doing it. Also need a test for that!

[nnecec]

Just add a --no-clean option and add test to integration tests.

Btw, I am a little confused, I can't figure out what difference between cli.test and integration.test. I feel like both are integration test cases.

[devjiwonchoi]

Maybe I could answer that for you, cli tests focus on targeting the CLI itself and the --args whereas integration is more of an E2E test that runs to meet the specific use cases.

[huozhi]

yeah would be good if we can move to cli test later, but it's not blocking for merging

[nnecec]

Maybe I could answer that for you, cli tests focus on targeting the CLI itself and the --args whereas integration is more of an E2E test that runs to meet the specific use cases.

thanks!

[huozhi]

Thanks!

Would be great if you use other branch or change the fork repo setting next time, I was trying to modify the code but seems not able to do it. Will follow up in different PRs

! [remote rejected] clean -> clean (permission denied)
error: failed to push some refs to 'https://github.com/nnecec/bunchee'

[nnecec]

Thanks!

Would be great if you use other branch or change the fork repo setting next time, I was trying to modify the code but seems not able to do it. Will follow up in different PRs

! [remote rejected] clean -> clean (permission denied)
error: failed to push some refs to 'nnecec/bunchee'

Got it! I'm sorry I didn't know that.

[huozhi]

No worries, probably just some random GitHub limitations