fix: ignore test file in prepare #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huozhi
reviewed
Jan 13, 2024
| @@ -0,0 +1 @@ | |||
| export const foo = 'foo' | |||
There was a problem hiding this comment.
We can delete foo.ts and bin/ as they're not relative for the tests
| it("bar", () => { | ||
| expect(true).toBe(true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
can you also run prettier format? I think the column can be erased, also will this file run in tests suite?
| @@ -0,0 +1,5 @@ | |||
| describe("foo", () => { | |||
There was a problem hiding this comment.
same, will this run? maybe change this to a spec file to cover .spec. case
src/utils.ts
Outdated
|
|
||
| export const isTestFile = (filename: string): boolean => | ||
| // include .test. or .spec. in filename | ||
| /\.(test|spec)\./.test(filename) |
There was a problem hiding this comment.
need to test baseNameWithoutExtension, cause it can be a.f.foo.spec.some.js which looks like a random valid case.
/\.(test|spec)$/.test(baseNameWithoutExtension(filename))
|
All updated. Thanks for your review. |
huozhi
reviewed
Jan 14, 2024
package.json
Outdated
| }, | ||
| "testPathIgnorePatterns": [ | ||
| "/node_modules/", | ||
| "<rootDir>/test/integration/prepare-ts-with-test-file/" |
There was a problem hiding this comment.
let’s ignore the tests from src/ folders under test/integration
test/integration/prepare-ts-with-test-file/src/index.react-server.ts
Outdated
Show resolved
Hide resolved
huozhi
reviewed
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398