Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Logging is off format #405

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: Logging is off format #405

merged 2 commits into from
Jan 17, 2024

Conversation

nnecec
Copy link
Contributor

@nnecec nnecec commented Jan 15, 2024 •
edited
Loading

resolve #404 (✌️I fixed the 404 issue)

Because of console.log will auto add a space between two args, I cancel combine arg + space like prefix before.

huozhi
huozhi reviewed Jan 15, 2024
View reviewed changes
Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can we add a test for this?

@nnecec
Copy link
Contributor Author

nnecec commented Jan 15, 2024

Thanks, can we add a test for this?

I'll try it tomorrow.

@nnecec nnecec changed the title fix: Logging is off format Draft: fix: Logging is off format Jan 16, 2024
huozhi
huozhi reviewed Jan 16, 2024
View reviewed changes
test/integration.test.ts Outdated Show resolved Hide resolved
nnecec
nnecec commented Jan 16, 2024
View reviewed changes
test/integration.test.ts Outdated Show resolved Hide resolved
@nnecec nnecec force-pushed the fix/logging-is-off-format branch 2 times, most recently from 11e91e8 to 419151c Compare January 16, 2024 17:13
huozhi
huozhi reviewed Jan 16, 2024
View reviewed changes
test/integration.test.ts Outdated Show resolved Hide resolved
test/integration.test.ts Outdated Show resolved Hide resolved
test/integration.test.ts Outdated Show resolved Hide resolved
src/plugins/output-state-plugin.ts Outdated Show resolved Hide resolved
@huozhi huozhi changed the title Draft: fix: Logging is off format fix: Logging is off format Jan 16, 2024
@nnecec nnecec force-pushed the fix/logging-is-off-format branch 3 times, most recently from 604d064 to 83b39a5 Compare January 17, 2024 06:31
@nnecec @huozhi
fix: Logging is off format
7f04a7c 
test: add tests for output format
huozhi
huozhi approved these changes Jan 17, 2024
View reviewed changes
Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@huozhi huozhi merged commit 39e143d into huozhi:main Jan 17, 2024
3 checks passed
@nnecec
Copy link
Contributor Author

nnecec commented Jan 18, 2024

Thanks too!

@nnecec nnecec deleted the fix/logging-is-off-format branch January 18, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging is off format
2 participants
@nnecec @huozhi