-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: print end status in watch mode #408
feat: print end status in watch mode #408
Conversation
Ignore this feat if you don't think it's necessary, just my personal opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a nice feature.
Can we polish the output to sth like
✓ Built in xxx ms
Without including the emoji and :
6a40946
to
0acbaf7
Compare
Now it look like > bunchee -w
Watching assets in /Users/nnecec/Github/bunchee...
✓ Build in 2875.94ms
src/bundle.ts(30,3): error TS6133: 'formatDuration' is declared but its value is never read.
✓ Build in 1541.16ms
✓ Build in 1727.21ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can we add a test? Then I will merge later release this in a minor version. Thank you!
d35d580
to
5fbad3c
Compare
5fbad3c
to
47575d6
Compare
I refactored a bit the code, to leverage the build jobs count instead of using another counter, since that one could be incorrect that it might reaches to 0 ealier |
I sometimes wonder if I've built done in watch mode, because it print nothing when built sucessfully.
Do we need to print some hint like these in watch mode?