test: separate tests

[nnecec]

resolve #389

[nnecec]

Is this the change we want? I can do more work if this is expected.

[huozhi]

Thanks for the PR. The expectation is each test will have its own test file like ./test/cli/<test case>/index.test.ts so the code are organized in the <test case> folder, and we can use a test helper to create test to write less code in each file

[nnecec]

I separated cli tests into multiple folders. If the same fixture is used, I put the test cases together in a index.test.ts.

Request CR, thanks!

[huozhi]

I was thinking to get a helper that automatically create a test directory for each test, and then use the fixed input filename, in each folder.

So each test you only need to call the helper, and pass the directory (maybe just __dirname) and received the code, stderr, stdout etc. you just need to test them. Similar to what we had before

// we have a generic helper `createTest`, that can define what does the executor do
const createCliTest = createTest({
   run(input, args) {
     // do cli work
     executeBunchee(...)
   }
})

// in each test, `createCliTest` can return the result
it(...) {
   const { code, stdout, distFiles, ... } = createCliTest({ directory: __dirname, args: [...] })
   // test stdout etc
}

[nnecec]

I think we could remove removeDirectory(distDir), because we create dist in fixtures instead of createTempDir

[huozhi]

There're code conflicts

[huozhi]

@nnecec The purpose to have cli and integration tests's cli separate is:

Integration tests shouldn't need to specify a folder, it should be current __dirname by default always, no args. If we have one test file for each folder, case, instead group some of them in fixtures.

- integration/<xxx>
  |- src/...
  |- package.json
  |- index.test.js

Cli tests can have flexible args, but if the input.js filename is a fixed convention we don't need to do it.

I didn't expect we gonna change integration as well, as the early draft is only about cli. This is kinda a pretty big change now. If would be great if we can land the cli tests changes first, since they're not too much.

Then we get a new PR to change one integration test as an example, if it looks good we can migrate rest of them. It doesn't have to be a one time all migrated change.

Thank you!

[huozhi]

This can be done in afterEach/afterAll

[huozhi]

Thanks for the PR, let's tackle the improves in the separate PR, will merge this for now