-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite exports parser #465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huozhi
force-pushed
the
fix/nested-dev-prod-exports
branch
from
February 25, 2024 23:55
fd0a222
to
1880bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way of how bunchee parsing package
exports
and matching with entries.While making the lint feature, I realize we could collect the source files first instead of do a matching for possible entry file when we create a job each time.
The approach now is to have a export path to output files and conditions mapping
If you have more special conditions, the export type will become a composed type connected by '.'
Then we'll collect all the entry files, including executable binaries, they'll be
As you can see, the entry
./index
will have 2 outputs: one is ESM format (import
), another is default format, thedefault
is based evaluated based on the package type.We'll normalize the keys of the collected entries key, and do a overlapping with the collected output files. So that each entry file with its corresponding output files can become the building jobs later.
Previous approah of parsing export paths is too complex especially composing with
development
andproduction
conditions.Fixes #469
Fixes #407