Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace rimraf #498

Merged
merged 1 commit into from
Mar 21, 2024
Merged

refactor: replace rimraf #498

merged 1 commit into from
Mar 21, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 21, 2024

bunchee targets Node.js 18 already, so it is safe to replace rimraf with the Node.js built-in fs.promise.rm method.

Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1000%

@huozhi huozhi merged commit 004b7c9 into huozhi:main Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants